Add icon button hover states and retire five deprecated colour aliases - #3248
Add icon button hover states and retire five deprecated colour aliases#3248tuguirazvan wants to merge 4 commits into
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (33)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP |  |
Aug 19, 2026 3:23p.m. | Review ↗ |
| JavaScript |  |
Aug 19, 2026 3:23p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
62d0df5 to
86bf452
Compare
The shortcode box, the email chips and the full screen close button had no hover state. The shortcode box also swapped its glyph in a single frame, so it now blooms in. The close button is sized from the icon button component in the Formidable System file and had no hit area of its own before. Adds --primary-100 and replaces --dark-grey, --grey, --grey-border, --primary-hover and --light-blue with the tokens they alias. --primary-color is deliberately left: Pro sets it inline as an override hook, so renaming its readers would silently break that and any customer CSS doing the same. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
86bf452 to
c9da5a7
Compare
…tton-states-token-cleanup # Conflicts: # js/formidable_admin.js
The same control ships under two classes: .frm-show-box opens the shortcode popup and .frm-show-inline-modal opens the inline one, including the boxes in the field options panel. Only the first had the hover, press and icon bloom, so the sidebar kept the untouched transition: all. Both the styles and the MutationObserver now match either class; the observer alone would have left the bloom silent even with the styles extended. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This branch had downgraded it to string concatenation, which oxlint's prefer-template rejects. Reverting to master's version removes the change from the diff entirely.
1 participant
The shortcode box, the email chips and the full screen close button each had a focus state and nothing for hover.
Pairs with Strategy11/formidable-pro#6561 for the alias sweep on the Pro side.
In this update,
MutationObservercovers every call site — noteattributeFiltercannot be used, as it misses thexlink:hrefwriteshideShortcodes()makes--small-radius). Its anchor had no dimensions before, so the target was only as big as the 20px glyph--primary-100, derived to sit between 50 and 200 at the spacing the grey ramp uses for its own 100--dark-grey,--grey,--grey-border,--primary-hoverand--light-bluein favour of the tokens they alias.--primary-coloris deliberately left alone: Pro sets it inline as an override hook, so renaming its readers would silently break that and any customer CSS doing the sameOn the red DeepSource check: it reports four issues in
admin.js(lines 7235, 7636, 7640, 8049). All four are pre-existing and unmodified — this PR adds three lines to that file, shifting them down by one, so DeepSource counts them as newly introduced. Left as-is rather than touching unrelated code.Merge order: none required. This stops core using the deprecated aliases but keeps all six defined in
_variables.scss, so Formidable Pro and any add-on reading them are unaffected whichever way round these land. Pairs with Strategy11/formidable-pro#6561, which does the same sweep on the Pro side.Follow-up, deliberately not done here: removing the definitions. That is the breaking change, and it can only happen once nothing references them — core is clean after this, Pro after #6561, but third-party add-ons and customer CSS are unknown. Worth its own PR in a release where a breaking-change note fits.